btrfs: remove free space cache inode check in btrfs_truncate_inode_items
authorJosef Bacik <josef@toxicpanda.com>
Fri, 3 Dec 2021 22:18:06 +0000 (17:18 -0500)
committerDavid Sterba <dsterba@suse.com>
Fri, 7 Jan 2022 13:18:24 +0000 (14:18 +0100)
We no longer have inode cache feature, so this check is extraneous as
the only inode cache is in the tree_root, which is not marked as
SHAREABLE.

Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode-item.c

index 604ace69574b20ac4c2c96330e5bd4fc7848e9cd..379baeccc7d670bfd23b8acda44efc7b92110d80 100644 (file)
@@ -477,12 +477,10 @@ int btrfs_truncate_inode_items(struct btrfs_trans_handle *trans,
        BUG_ON(new_size > 0 && min_type != BTRFS_EXTENT_DATA_KEY);
 
        /*
-        * For non-free space inodes and non-shareable roots, we want to back
-        * off from time to time.  This means all inodes in subvolume roots,
-        * reloc roots, and data reloc roots.
+        * For shareable roots we want to back off from time to time, this turns
+        * out to be subvolume roots, reloc roots, and data reloc roots.
         */
-       if (!btrfs_is_free_space_inode(inode) &&
-           test_bit(BTRFS_ROOT_SHAREABLE, &root->state))
+       if (test_bit(BTRFS_ROOT_SHAREABLE, &root->state))
                be_nice = true;
 
        path = btrfs_alloc_path();