usb: dwc3: gadget: ep_queue simplify isoc start condition
authorMichael Grzeschik <m.grzeschik@pengutronix.de>
Sun, 6 Mar 2022 21:12:50 +0000 (22:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Mar 2022 17:42:32 +0000 (18:42 +0100)
To improve reading the code this patch moves the cases to start_isoc or
return the function under one common condition check.

Reviewed-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Link: https://lore.kernel.org/r/20220306211251.2281335-2-m.grzeschik@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/gadget.c

index eb88ef5dd16ff0c412133be6820293e0ee4c62f6..416187189bdde1ea0aee6494412eff03b1d00c52 100644 (file)
@@ -1919,13 +1919,11 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req)
         * errors which will force us issue EndTransfer command.
         */
        if (usb_endpoint_xfer_isoc(dep->endpoint.desc)) {
-               if (!(dep->flags & DWC3_EP_PENDING_REQUEST) &&
-                               !(dep->flags & DWC3_EP_TRANSFER_STARTED))
-                       return 0;
-
-               if ((dep->flags & DWC3_EP_PENDING_REQUEST)) {
-                       if (!(dep->flags & DWC3_EP_TRANSFER_STARTED))
+               if (!(dep->flags & DWC3_EP_TRANSFER_STARTED)) {
+                       if ((dep->flags & DWC3_EP_PENDING_REQUEST))
                                return __dwc3_gadget_start_isoc(dep);
+
+                       return 0;
                }
        }