wifi: mt76: mt7915: check devm_kasprintf() returned value
authorMa Ke <make24@iscas.ac.cn>
Tue, 3 Sep 2024 01:49:55 +0000 (09:49 +0800)
committerFelix Fietkau <nbd@nbd.name>
Fri, 6 Sep 2024 12:23:07 +0000 (14:23 +0200)
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Link: https://patch.msgid.link/20240903014955.4145423-1-make24@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7915/init.c

index 511e0d04eb95519c15a9fbc9b4b88652ef8217d5..6bef96e3d2a3d9543fcb716aacaefe81ac2b91b9 100644 (file)
@@ -194,6 +194,8 @@ static int mt7915_thermal_init(struct mt7915_phy *phy)
 
        name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7915_%s",
                              wiphy_name(wiphy));
+       if (!name)
+               return -ENOMEM;
 
        cdev = thermal_cooling_device_register(name, phy, &mt7915_thermal_ops);
        if (!IS_ERR(cdev)) {