Btrfs: consistent usage of types in balance_args
authorHans van Kranenburg <hans.van.kranenburg@mendix.com>
Wed, 8 Mar 2017 17:58:43 +0000 (18:58 +0100)
committerDavid Sterba <dsterba@suse.com>
Tue, 18 Apr 2017 12:07:25 +0000 (14:07 +0200)
The btrfs_balance_args are only used for the balance ioctl, so use __u
instead of __le here for consistency. The __le usage was introduced in
bc3094673f22d and dee32d0ac3719 and was probably a result of
copy/pasting when the code was written.

The usage of __le did not break anything, but it's unnecessary. Also,
this change makes the code less confusing for the careful reader.

Signed-off-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
include/uapi/linux/btrfs.h

index dcfc3a5a9cb1d20f29bbac00c6ef315006e9d208..a456e5309238bbd78466abee16a0da6ab0248e50 100644 (file)
@@ -291,10 +291,10 @@ struct btrfs_ioctl_feature_flags {
 struct btrfs_balance_args {
        __u64 profiles;
        union {
-               __le64 usage;
+               __u64 usage;
                struct {
-                       __le32 usage_min;
-                       __le32 usage_max;
+                       __u32 usage_min;
+                       __u32 usage_max;
                };
        };
        __u64 devid;
@@ -324,8 +324,8 @@ struct btrfs_balance_args {
         * Process chunks that cross stripes_min..stripes_max devices,
         * BTRFS_BALANCE_ARGS_STRIPES_RANGE
         */
-       __le32 stripes_min;
-       __le32 stripes_max;
+       __u32 stripes_min;
+       __u32 stripes_max;
 
        __u64 unused[6];
 } __attribute__ ((__packed__));