spi: gpio: Support a single always-selected device
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 5 Feb 2025 13:19:20 +0000 (15:19 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 5 Feb 2025 13:52:57 +0000 (13:52 +0000)
The generic SPI code, the SPI GPIO driver functions support
a single always-connected device cases. The only impediment
is that board instantiation prevents that from happening.
Update spi_gpio_probe_pdata() checks to support the mentioned
hardware setup.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250205132127.742750-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-gpio.c

index 80a1aed4295183e99ed7091eaaaa1f70a3ac7a01..405deb6677c17c8b37036f1a9daab485347dcd20 100644 (file)
@@ -313,15 +313,14 @@ static int spi_gpio_probe_pdata(struct platform_device *pdev,
        struct spi_gpio *spi_gpio = spi_controller_get_devdata(host);
        int i;
 
-       if (!pdata || !pdata->num_chipselect)
+       if (!pdata)
                return -ENODEV;
 
-       /*
-        * The host needs to think there is a chipselect even if not
-        * connected
-        */
-       host->num_chipselect = pdata->num_chipselect ?: 1;
+       /* It's just one always-selected device, fine to continue */
+       if (!pdata->num_chipselect)
+               return 0;
 
+       host->num_chipselect = pdata->num_chipselect;
        spi_gpio->cs_gpios = devm_kcalloc(dev, host->num_chipselect,
                                          sizeof(*spi_gpio->cs_gpios),
                                          GFP_KERNEL);