smb: client: Use min() macro
authorShen Lichuan <shenlichuan@vivo.com>
Tue, 27 Aug 2024 08:54:20 +0000 (16:54 +0800)
committerSteve French <stfrench@microsoft.com>
Sun, 15 Sep 2024 15:42:44 +0000 (10:42 -0500)
Use the min() macro to simplify the function and improve
its readability.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/cifsacl.c
fs/smb/client/smbdirect.c

index e2ec1d9343354dd74713726f9632505537c7c4f9..1d294d53f662479c0323d5f5a645478c6f590062 100644 (file)
@@ -187,7 +187,7 @@ compare_sids(const struct smb_sid *ctsid, const struct smb_sid *cwsid)
        /* compare all of the subauth values if any */
        num_sat = ctsid->num_subauth;
        num_saw = cwsid->num_subauth;
-       num_subauth = num_sat < num_saw ? num_sat : num_saw;
+       num_subauth = min(num_sat, num_saw);
        if (num_subauth) {
                for (i = 0; i < num_subauth; ++i) {
                        if (ctsid->sub_auth[i] != cwsid->sub_auth[i]) {
index 7bcc379014cadd4e20415b6a06914e3ad33744f8..8f782edc3fd7f21fb7f50bf34f3d0a785e607168 100644 (file)
@@ -1585,10 +1585,8 @@ static struct smbd_connection *_smbd_get_connection(
        conn_param.initiator_depth = 0;
 
        conn_param.responder_resources =
-               info->id->device->attrs.max_qp_rd_atom
-                       < SMBD_CM_RESPONDER_RESOURCES ?
-               info->id->device->attrs.max_qp_rd_atom :
-               SMBD_CM_RESPONDER_RESOURCES;
+               min(info->id->device->attrs.max_qp_rd_atom,
+                   SMBD_CM_RESPONDER_RESOURCES);
        info->responder_resources = conn_param.responder_resources;
        log_rdma_mr(INFO, "responder_resources=%d\n",
                info->responder_resources);