net: ucc_geth: fix usage with NVMEM MAC address
authorRosen Penev <rosenp@gmail.com>
Mon, 4 Nov 2024 21:01:27 +0000 (13:01 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 7 Nov 2024 01:54:47 +0000 (17:54 -0800)
When nvmem is not ready, of_get_ethdev_address returns -EPROBE_DEFER. In
such a case, return -EPROBE_DEFER to avoid not having a proper MAC
address.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20241104210127.307420-5-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/ucc_geth.c

index acadebb7dd34f559a9261e19cc79ecbe5fd63fc9..6663c176808928ce364c70be042ee2a976c4f8e0 100644 (file)
@@ -3732,7 +3732,9 @@ static int ucc_geth_probe(struct platform_device* ofdev)
                goto err_deregister_fixed_link;
        }
 
-       of_get_ethdev_address(np, dev);
+       err = of_get_ethdev_address(np, dev);
+       if (err == -EPROBE_DEFER)
+               goto err_deregister_fixed_link;
 
        ugeth->ug_info = ug_info;
        ugeth->dev = device;