net: openvswitch: Check vport netdev name
authorJun Gu <jun.gu@easystack.cn>
Fri, 19 Apr 2024 06:14:25 +0000 (14:14 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 23 Apr 2024 00:34:02 +0000 (17:34 -0700)
Ensure that the provided netdev name is not one of its aliases to
prevent unnecessary creation and destruction of the vport by
ovs-vswitchd.

Signed-off-by: Jun Gu <jun.gu@easystack.cn>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Link: https://lore.kernel.org/r/20240419061425.132723-1-jun.gu@easystack.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/openvswitch/vport-netdev.c

index 903537a5da22ea434302c06d2f4931f13ff2ec27..618edc346c0fd05d08495e94f0a0722a568df035 100644 (file)
@@ -78,7 +78,10 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)
        int err;
 
        vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
-       if (!vport->dev) {
+       /* Ensure that the device exists and that the provided
+        * name is not one of its aliases.
+        */
+       if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
                err = -ENODEV;
                goto error_free_vport;
        }