typec: tcpm: Fix incorrect 'and' operator
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 30 Apr 2018 13:23:06 +0000 (08:23 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Apr 2018 16:05:44 +0000 (09:05 -0700)
Currently, logical and is being used instead of *bitwise* and.

Fix this by using a proper bitwise and operator.

Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator")
Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related messages")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm.c

index 1ee259bc14a511e2a0e9bb14377587634ab6ca85..7ee417a525c31488c68987ad21903111b4997610 100644 (file)
@@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port *port,
        enum pd_ext_msg_type type = pd_header_type_le(msg->header);
        unsigned int data_size = pd_ext_header_data_size_le(msg->ext_msg.header);
 
-       if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) {
+       if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) {
                tcpm_log(port, "Unchunked extended messages unsupported");
                return;
        }