i2c: mux: gpio: use gpio_set_value_cansleep()
authorIonut Nicu <ioan.nicu.ext@nsn.com>
Fri, 11 Oct 2013 12:17:10 +0000 (14:17 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Wed, 30 Oct 2013 16:29:40 +0000 (17:29 +0100)
Some gpio chips may have get/set operations that
can sleep. gpio_set_value() only works for chips
which do not sleep, for the others we will get a
kernel warning. Using gpio_set_value_cansleep()
will work for both chips that do sleep and those
who don't.

Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org
drivers/i2c/muxes/i2c-mux-gpio.c

index 927a7deafd2171fedcef7e9111dc4048b669f73c..cf93f10b59af1aa6da778af5a67f569f073d90f2 100644 (file)
@@ -30,8 +30,8 @@ static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
        int i;
 
        for (i = 0; i < mux->data.n_gpios; i++)
-               gpio_set_value(mux->gpio_base + mux->data.gpios[i],
-                              val & (1 << i));
+               gpio_set_value_cansleep(mux->gpio_base + mux->data.gpios[i],
+                                       val & (1 << i));
 }
 
 static int i2c_mux_gpio_select(struct i2c_adapter *adap, void *data, u32 chan)