drm/vkms: check plane_composer->map[0] before using it
authorTales Lelo da Aparecida <tales.aparecida@gmail.com>
Fri, 15 Apr 2022 11:12:59 +0000 (08:12 -0300)
committerMelissa Wen <melissa.srw@gmail.com>
Sun, 12 Jun 2022 23:14:03 +0000 (22:14 -0100)
Fix a copypasta error. The caller of compose_plane() already checks
primary_composer->map. In contrast, plane_composer->map is never
verified here before handling.

Fixes: 7938f4218168 ("dma-buf-map: Rename to iosys-map")
Reviewed-by: André Almeida <andrealmeid@riseup.net>
Signed-off-by: Tales Lelo da Aparecida <tales.aparecida@gmail.com>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220415111300.61013-2-tales.aparecida@gmail.com
drivers/gpu/drm/vkms/vkms_composer.c

index 914c0ac7dc8b173ca6f3b9dfa3572874551fac8a..0f5655f726404af1e864502728782ee827625ea1 100644 (file)
@@ -157,7 +157,7 @@ static void compose_plane(struct vkms_composer *primary_composer,
        void *vaddr;
        void (*pixel_blend)(const u8 *p_src, u8 *p_dst);
 
-       if (WARN_ON(iosys_map_is_null(&primary_composer->map[0])))
+       if (WARN_ON(iosys_map_is_null(&plane_composer->map[0])))
                return;
 
        vaddr = plane_composer->map[0].vaddr;