serial: pic32_uart: Fix double free of 'sport->irq_fault_name'.
authorPurna Chandra Mandal <purna.mandal@microchip.com>
Tue, 17 May 2016 05:05:54 +0000 (10:35 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Jun 2016 20:50:53 +0000 (13:50 -0700)
Allocated memory for 'sport->irq_fault_name' is freed twice, first
in error check of 'if(!sport->irq_rx_name)' and other in fallback
handler.

Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/pic32_uart.c

index 62a43bf5698e5e3c335933ade8659eaa05d1a709..7f8e99bbcb739832824682ebe7321c7c653a22da 100644 (file)
@@ -445,7 +445,6 @@ static int pic32_uart_startup(struct uart_port *port)
                                       sport->idx);
        if (!sport->irq_rx_name) {
                dev_err(port->dev, "%s: kasprintf err!", __func__);
-               kfree(sport->irq_fault_name);
                ret = -ENOMEM;
                goto out_f;
        }