genksyms: refactor the return points in the for-loop in __add_symbol()

free_list() must be called before returning from this for-loop.

Swap 'break' and the combination of free_list() and 'return'.

This reduces the code and minimizes the risk of introducing memory
leaks in future changes.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

diff --git a/scripts/genksyms/genksyms.c b/scripts/genksyms/genksyms.c
index 5a90acd693f44cbeed25ee4ab435f9eb83521a2a..41d6cfce0088fa392478aceba6629630a5bb02a0 100644 (file)
--- a/scripts/genksyms/genksyms.c
+++ b/scripts/genksyms/genksyms.c
@@ -231,7 +231,7 @@ static struct symbol *__add_symbol(const char *name, enum symbol_type type,
                        continue;
 
                if (is_reference) {
-                       /* fall through */ ;
+                       break;
                } else if (sym->type == type && equal_list(sym->defn, defn)) {
                        if (!sym->is_declared && sym->is_override) {
                                print_location();
@@ -239,25 +239,21 @@ static struct symbol *__add_symbol(const char *name, enum symbol_type type,
                                fprintf(stderr, " modversion is unchanged\n");
                        }
                        sym->is_declared = 1;
-                       free_list(defn, NULL);
-                       return sym;
                } else if (sym->is_declared) {
                        error_with_pos("redefinition of %s", name);
-                       free_list(defn, NULL);
-                       return sym;
                } else if (sym->is_override && flag_preserve) {
                        print_location();
                        fprintf(stderr, "ignoring ");
                        print_type_name(type, name);
                        fprintf(stderr, " modversion change\n");
                        sym->is_declared = 1;
-                       free_list(defn, NULL);
-                       return sym;
                } else {
                        status = is_unknown_symbol(sym) ?
                                        STATUS_DEFINED : STATUS_MODIFIED;
+                       break;
                }
-               break;
+               free_list(defn, NULL);
+               return sym;
        }
 
        if (sym) {