drm/amd/display: Handle HPD_IRQ for internal link
authorSung-huai Wang <danny.wang@amd.com>
Wed, 10 Apr 2024 06:40:32 +0000 (14:40 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 30 Apr 2024 13:45:54 +0000 (09:45 -0400)
[Why]
TCON data is corrupted after electro static discharge test.
Once the TCON data get corrupted, they will get themselves
reset and send HPD_IRQ to source side.

[How]
Support HPD_IRQ for internal link, and restore the PSR/Replay setup.

Reviewed-by: Robin Chen <robin.chen@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Sung-huai Wang <danny.wang@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_irq_handler.c

index 0fcf0b8530acf091712630ae0e1897559a53deb4..659b8064d3618cfce95f0e221e44c8a33ade327a 100644 (file)
@@ -373,6 +373,7 @@ bool dp_handle_hpd_rx_irq(struct dc_link *link,
        union device_service_irq device_service_clear = {0};
        enum dc_status result;
        bool status = false;
+       bool allow_active = false;
 
        if (out_link_loss)
                *out_link_loss = false;
@@ -427,12 +428,6 @@ bool dp_handle_hpd_rx_irq(struct dc_link *link,
                return false;
        }
 
-       if (handle_hpd_irq_psr_sink(link))
-               /* PSR-related error was detected and handled */
-               return true;
-
-       handle_hpd_irq_replay_sink(link);
-
        /* If PSR-related error handled, Main link may be off,
         * so do not handle as a normal sink status change interrupt.
         */
@@ -454,9 +449,8 @@ bool dp_handle_hpd_rx_irq(struct dc_link *link,
         * If we got sink count changed it means
         * Downstream port status changed,
         * then DM should call DC to do the detection.
-        * NOTE: Do not handle link loss on eDP since it is internal link*/
-       if ((link->connector_signal != SIGNAL_TYPE_EDP) &&
-                       dp_parse_link_loss_status(
+        */
+       if (dp_parse_link_loss_status(
                                        link,
                                        &hpd_irq_dpcd_data)) {
                /* Connectivity log: link loss */
@@ -465,6 +459,11 @@ bool dp_handle_hpd_rx_irq(struct dc_link *link,
                                        sizeof(hpd_irq_dpcd_data),
                                        "Status: ");
 
+               if (link->psr_settings.psr_feature_enabled)
+                       edp_set_psr_allow_active(link, &allow_active, true, false, NULL);
+               else if (link->replay_settings.replay_allow_active)
+                       edp_set_replay_allow_active(link, &allow_active, true, false, NULL);
+
                if (defer_handling && has_left_work)
                        *has_left_work = true;
                else
@@ -477,6 +476,14 @@ bool dp_handle_hpd_rx_irq(struct dc_link *link,
                dp_trace_link_loss_increment(link);
        }
 
+       if (*out_link_loss == false) {
+               if (handle_hpd_irq_psr_sink(link))
+                       /* PSR-related error was detected and handled */
+                       return true;
+
+               handle_hpd_irq_replay_sink(link);
+       }
+
        if (link->type == dc_connection_sst_branch &&
                hpd_irq_dpcd_data.bytes.sink_cnt.bits.SINK_COUNT
                        != link->dpcd_sink_count)