ipmi: ipmb: Add check devm_kasprintf() returned value
authorCharles Han <hanchunchao@inspur.com>
Thu, 26 Sep 2024 09:44:19 +0000 (17:44 +0800)
committerCorey Minyard <corey@minyard.net>
Fri, 27 Sep 2024 00:18:48 +0000 (19:18 -0500)
devm_kasprintf() can return a NULL pointer on failure but this
returned value is not checked.

Fixes: 51bd6f291583 ("Add support for IPMB driver")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Message-ID: <20240926094419.25900-1-hanchunchao@inspur.com>
Signed-off-by: Corey Minyard <corey@minyard.net>
drivers/char/ipmi/ipmb_dev_int.c

index 7296127181eca330f0bff5f56631e4e64473e190..8a14fd0291d89b9afce0b944ef99b56862a6f660 100644 (file)
@@ -321,6 +321,9 @@ static int ipmb_probe(struct i2c_client *client)
        ipmb_dev->miscdev.name = devm_kasprintf(&client->dev, GFP_KERNEL,
                                                "%s%d", "ipmb-",
                                                client->adapter->nr);
+       if (!ipmb_dev->miscdev.name)
+               return -ENOMEM;
+
        ipmb_dev->miscdev.fops = &ipmb_fops;
        ipmb_dev->miscdev.parent = &client->dev;
        ret = misc_register(&ipmb_dev->miscdev);