selftests/coredump: Remove the read() that fails the test
authorNam Cao <namcao@linutronix.de>
Mon, 11 Aug 2025 07:49:57 +0000 (09:49 +0200)
committerChristian Brauner <brauner@kernel.org>
Mon, 11 Aug 2025 13:43:31 +0000 (15:43 +0200)
Resolve a conflict between
  commit 6a68d28066b6 ("selftests/coredump: Fix "socket_detect_userspace_client" test failure")
and
  commit 994dc26302ed ("selftests/coredump: fix build")

The first commit adds a read() to wait for write() from another thread to
finish. But the second commit removes the write().

Now that the two commits are in the same tree, the read() now gets EOF and
the test fails.

Remove this read() so that the test passes.

Signed-off-by: Nam Cao <namcao@linutronix.de>
Link: https://lore.kernel.org/20250811074957.4079616-1-namcao@linutronix.de
Signed-off-by: Christian Brauner <brauner@kernel.org>
tools/testing/selftests/coredump/stackdump_test.c

index 5a5a7a5f7e1ddb3f58f6a3cfb8029abfde1ca198..a4ac80bb10038d7f9ab27b56da6a79f5cc59e8a6 100644 (file)
@@ -446,9 +446,6 @@ TEST_F(coredump, socket_detect_userspace_client)
                if (info.coredump_mask & PIDFD_COREDUMPED)
                        goto out;
 
-               if (read(fd_coredump, &c, 1) < 1)
-                       goto out;
-
                exit_code = EXIT_SUCCESS;
 out:
                if (fd_peer_pidfd >= 0)