net/mlx5: Fix tainted pointer delete is case of flow rules creation fail

In case of flow rule creation fail in mlx5_lag_create_port_sel_table(),
instead of previously created rules, the tainted pointer is deleted
deveral times.
Fix this bug by using correct flow rules pointers.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 352899f384d4 ("net/mlx5: Lag, use buckets in hash mode")
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/r/20240604100552.25201-1-amishin@t-argos.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
index c16b462ddedf7e6914f0c0b796f68ee2ae2bf189..ab2717012b79b5bd115b73a5cd71e245c6045979 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
@@ -88,9 +88,13 @@ static int mlx5_lag_create_port_sel_table(struct mlx5_lag *ldev,
                                                                      &dest, 1);
                        if (IS_ERR(lag_definer->rules[idx])) {
                                err = PTR_ERR(lag_definer->rules[idx]);
-                               while (i--)
-                                       while (j--)
+                               do {
+                                       while (j--) {
+                                               idx = i * ldev->buckets + j;
                                                mlx5_del_flow_rules(lag_definer->rules[idx]);
+                                       }
+                                       j = ldev->buckets;
+                               } while (i--);
                                goto destroy_fg;
                        }
                }