drm/ssd130x: ensure ssd132x pitch is correct
authorJohn Keeping <jkeeping@inmusicbrands.com>
Wed, 15 Jan 2025 11:01:38 +0000 (11:01 +0000)
committerJavier Martinez Canillas <javierm@redhat.com>
Thu, 16 Jan 2025 09:48:47 +0000 (10:48 +0100)
The bounding rectangle is adjusted to ensure it aligns to
SSD132X_SEGMENT_WIDTH, which may adjust the pitch.  Calculate the pitch
after aligning the left and right edge.

Fixes: fdd591e00a9c ("drm/ssd130x: Add support for the SSD132x OLED controller family")
Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250115110139.1672488-3-jkeeping@inmusicbrands.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
drivers/gpu/drm/solomon/ssd130x.c

index 4bb663f984ce3ccbb581d02e327b3118af7e7068..dd2006d51c7a2fc8501904565da806aa47333ad6 100644 (file)
@@ -1037,7 +1037,7 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffer *fb,
                                struct drm_format_conv_state *fmtcnv_state)
 {
        struct ssd130x_device *ssd130x = drm_to_ssd130x(fb->dev);
-       unsigned int dst_pitch = drm_rect_width(rect);
+       unsigned int dst_pitch;
        struct iosys_map dst;
        int ret = 0;
 
@@ -1046,6 +1046,8 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffer *fb,
        rect->x2 = min_t(unsigned int, round_up(rect->x2, SSD132X_SEGMENT_WIDTH),
                         ssd130x->width);
 
+       dst_pitch = drm_rect_width(rect);
+
        ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE);
        if (ret)
                return ret;