s390/pai: fix attr_event_free upper limit for pai device drivers

When the device drivers are initialized, a sysfs directory
is created. This contains many attributes which are allocated with
kzalloc(). Should it fail, the memory for the attributes already
created is freed in attr_event_free(). Its second parameter is number
of attribute elements to delete. This parameter is off by one.
When i. e. the 10th attribute fails to get created, attributes
numbered 0 to 9 should be deleted. Currently only attributes
numbered 0 to 8 are deleted.

Fixes: 39d62336f5c1 ("s390/pai: add support for cryptography counters")
Reported-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Acked-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

diff --git a/arch/s390/kernel/perf_pai_crypto.c b/arch/s390/kernel/perf_pai_crypto.c
index bf8a672b15a41afd3a9e0384ad19f83eb8eadba1..522a5ea0a9f49c68b52b4426533f23f2c314baa4 100644 (file)
--- a/arch/s390/kernel/perf_pai_crypto.c
+++ b/arch/s390/kernel/perf_pai_crypto.c
@@ -721,7 +721,7 @@ static int __init attr_event_init(void)
        for (i = 0; i < ARRAY_SIZE(paicrypt_ctrnames); i++) {
                ret = attr_event_init_one(attrs, i);
                if (ret) {
-                       attr_event_free(attrs, i - 1);
+                       attr_event_free(attrs, i);
                        return ret;
                }
        }

diff --git a/arch/s390/kernel/perf_pai_ext.c b/arch/s390/kernel/perf_pai_ext.c
index af7f2b538c8fd47a19f73029264462bd6c4fdcbd..95d1a890640a389f3f3917b9a1bb7a46fdd736a5 100644 (file)
--- a/arch/s390/kernel/perf_pai_ext.c
+++ b/arch/s390/kernel/perf_pai_ext.c
@@ -611,7 +611,7 @@ static int __init attr_event_init(void)
        for (i = 0; i < ARRAY_SIZE(paiext_ctrnames); i++) {
                ret = attr_event_init_one(attrs, i);
                if (ret) {
-                       attr_event_free(attrs, i - 1);
+                       attr_event_free(attrs, i);
                        return ret;
                }
        }