PM: sleep: stats: Use unsigned int for success and failure counters
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 29 Jan 2024 16:13:14 +0000 (17:13 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 5 Feb 2024 13:26:27 +0000 (14:26 +0100)
Change the type of the "success" and "fail" fields in struct
suspend_stats to unsigned int, because they cannot be negative.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
include/linux/suspend.h
kernel/power/main.c

index 5e4c4d4aed956550202891eff8fa7c7b8125c541..216bae9895357ecebb61dc8ddbebeb6a52e30aef 100644 (file)
@@ -56,8 +56,8 @@ enum suspend_stat_step {
 
 struct suspend_stats {
        unsigned int step_failures[SUSPEND_NR_STEPS];
-       int     success;
-       int     fail;
+       unsigned int success;
+       unsigned int fail;
 #define        REC_FAILED_NUM  2
        int     last_failed_dev;
        char    failed_devs[REC_FAILED_NUM][40];
index d7a02105b18366b22016088d7ab9597596f81612..d6b4a925828894cf2dec32261050a500594d62be 100644 (file)
@@ -339,8 +339,8 @@ static ssize_t _name##_show(struct kobject *kobj,           \
 }                                                              \
 static struct kobj_attribute _name = __ATTR_RO(_name)
 
-suspend_attr(success, "%d\n");
-suspend_attr(fail, "%d\n");
+suspend_attr(success, "%u\n");
+suspend_attr(fail, "%u\n");
 suspend_attr(last_hw_sleep, "%llu\n");
 suspend_attr(total_hw_sleep, "%llu\n");
 suspend_attr(max_hw_sleep, "%llu\n");
@@ -458,7 +458,7 @@ static int suspend_stats_show(struct seq_file *s, void *unused)
        last_step = suspend_stats.last_failed_step + REC_FAILED_NUM - 1;
        last_step %= REC_FAILED_NUM;
 
-       seq_printf(s, "success: %d\nfail: %d\n",
+       seq_printf(s, "success: %u\nfail: %u\n",
                   suspend_stats.success, suspend_stats.fail);
 
        for (step = SUSPEND_FREEZE; step <= SUSPEND_NR_STEPS; step++)