ubiblock: pass queue_limits to blk_mq_alloc_disk
authorChristoph Hellwig <hch@lst.de>
Thu, 15 Feb 2024 07:02:57 +0000 (08:02 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 19 Feb 2024 23:59:32 +0000 (16:59 -0700)
Pass the few limits ubiblock imposes directly to blk_mq_alloc_disk
instead of setting them one at a time.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Link: https://lore.kernel.org/r/20240215070300.2200308-15-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/mtd/ubi/block.c

index 9be87c231a2eba40800cd69357d0eba10a4703f2..5c8fdcc088a0df73e4ee4684a4406780fddd978e 100644 (file)
@@ -348,6 +348,9 @@ static int calc_disk_capacity(struct ubi_volume_info *vi, u64 *disk_capacity)
 
 int ubiblock_create(struct ubi_volume_info *vi)
 {
+       struct queue_limits lim = {
+               .max_segments           = UBI_MAX_SG_COUNT,
+       };
        struct ubiblock *dev;
        struct gendisk *gd;
        u64 disk_capacity;
@@ -393,7 +396,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
 
 
        /* Initialize the gendisk of this ubiblock device */
-       gd = blk_mq_alloc_disk(&dev->tag_set, NULL, dev);
+       gd = blk_mq_alloc_disk(&dev->tag_set, &lim, dev);
        if (IS_ERR(gd)) {
                ret = PTR_ERR(gd);
                goto out_free_tags;
@@ -416,7 +419,6 @@ int ubiblock_create(struct ubi_volume_info *vi)
        dev->gd = gd;
 
        dev->rq = gd->queue;
-       blk_queue_max_segments(dev->rq, UBI_MAX_SG_COUNT);
 
        list_add_tail(&dev->list, &ubiblock_devices);