net: hns3: fix reset timeout under full functions and queues
authorPeiyang Wang <wangpeiyang1@huawei.com>
Thu, 7 Mar 2024 01:01:13 +0000 (09:01 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Mar 2024 12:01:32 +0000 (12:01 +0000)
The cmdq reset command times out when all VFs are enabled and the queue is
full. The hardware processing time exceeds the timeout set by the driver.
In order to avoid the above extreme situations, the driver extends the
reset timeout to 1 second.

Signed-off-by: Peiyang Wang <wangpeiyang1@huawei.com>
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Sunil Goutham <sgoutham@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_cmd.c
drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_cmd.h

index d92ad6082d8ed60696d1fb0d3d6bb0b6b3b00cf5..652d71326231ad729b35ce6d89650f1b03f6d144 100644 (file)
@@ -351,7 +351,7 @@ static int hclge_comm_cmd_csq_done(struct hclge_comm_hw *hw)
 static u32 hclge_get_cmdq_tx_timeout(u16 opcode, u32 tx_timeout)
 {
        static const struct hclge_cmdq_tx_timeout_map cmdq_tx_timeout_map[] = {
-               {HCLGE_OPC_CFG_RST_TRIGGER, HCLGE_COMM_CMDQ_TX_TIMEOUT_500MS},
+               {HCLGE_OPC_CFG_RST_TRIGGER, HCLGE_COMM_CMDQ_CFG_RST_TIMEOUT},
        };
        u32 i;
 
index 533c19d25e4f6d0ff57f9d5c7a92ace3ba38045b..552396518e08add03a365b0ff36c8cde1046523a 100644 (file)
@@ -55,7 +55,7 @@
 #define HCLGE_COMM_NIC_CMQ_DESC_NUM_S          3
 #define HCLGE_COMM_NIC_CMQ_DESC_NUM            1024
 #define HCLGE_COMM_CMDQ_TX_TIMEOUT_DEFAULT     30000
-#define HCLGE_COMM_CMDQ_TX_TIMEOUT_500MS       500000
+#define HCLGE_COMM_CMDQ_CFG_RST_TIMEOUT                1000000
 
 enum hclge_opcode_type {
        /* Generic commands */