drm/i915/dsi: assume BXT gpio works for non-native GPIO
authorJani Nikula <jani.nikula@intel.com>
Fri, 3 Nov 2023 20:18:16 +0000 (22:18 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 22 Nov 2023 16:50:01 +0000 (18:50 +0200)
Purely a guess. Drop the nop function.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231103201831.1037416-2-andriy.shevchenko@linux.intel.com
drivers/gpu/drm/i915/display/intel_dsi_vbt.c

index 24b2cbcfc1effb272acbe55dae56499f54c18278..b2c0cc11f8c17c2d4218b7db805bbe3c0efe9624 100644 (file)
@@ -372,14 +372,6 @@ static void bxt_exec_gpio(struct intel_connector *connector,
        gpiod_set_value(gpio_desc, value);
 }
 
-static void icl_exec_gpio(struct intel_connector *connector,
-                         u8 gpio_source, u8 gpio_index, bool value)
-{
-       struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-
-       drm_dbg_kms(&dev_priv->drm, "Skipping ICL GPIO element execution\n");
-}
-
 enum {
        MIPI_RESET_1 = 0,
        MIPI_AVDD_EN_1,
@@ -491,7 +483,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
        if (native)
                icl_native_gpio_set_value(dev_priv, gpio_number, value);
        else if (DISPLAY_VER(dev_priv) >= 11)
-               icl_exec_gpio(connector, gpio_source, gpio_index, value);
+               bxt_exec_gpio(connector, gpio_source, gpio_index, value);
        else if (IS_VALLEYVIEW(dev_priv))
                vlv_exec_gpio(connector, gpio_source, gpio_number, value);
        else if (IS_CHERRYVIEW(dev_priv))