powerpc/fadump: Use swap() instead of open coding it
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Sat, 29 Jan 2022 03:48:47 +0000 (11:48 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 4 May 2022 09:37:45 +0000 (19:37 +1000)
Clean the following coccicheck warning:

./arch/powerpc/kernel/fadump.c:1291:34-35: WARNING opportunity for
swap().

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220129034847.76902-1-jiapeng.chong@linux.alibaba.com
arch/powerpc/kernel/fadump.c

index 0874684683a4c7c0907f8e25319abc01e0f11656..b59ee7053bba2a6caa54600039d317bbccec4e0c 100644 (file)
@@ -1285,7 +1285,6 @@ static void fadump_release_reserved_area(u64 start, u64 end)
 static void sort_and_merge_mem_ranges(struct fadump_mrange_info *mrange_info)
 {
        struct fadump_memory_range *mem_ranges;
-       struct fadump_memory_range tmp_range;
        u64 base, size;
        int i, j, idx;
 
@@ -1300,11 +1299,8 @@ static void sort_and_merge_mem_ranges(struct fadump_mrange_info *mrange_info)
                        if (mem_ranges[idx].base > mem_ranges[j].base)
                                idx = j;
                }
-               if (idx != i) {
-                       tmp_range = mem_ranges[idx];
-                       mem_ranges[idx] = mem_ranges[i];
-                       mem_ranges[i] = tmp_range;
-               }
+               if (idx != i)
+                       swap(mem_ranges[idx], mem_ranges[i]);
        }
 
        /* Merge adjacent reserved ranges */