soc: ti: pruss: Fix pruss APIs
authorMD Danish Anwar <danishanwar@ti.com>
Fri, 20 Dec 2024 10:05:07 +0000 (15:35 +0530)
committerNishanth Menon <nm@ti.com>
Thu, 2 Jan 2025 16:37:14 +0000 (10:37 -0600)
PRUSS APIs in pruss_driver.h produce lots of compilation errors when
CONFIG_TI_PRUSS is not set.

The errors and warnings,
warning: returning 'void *' from a function with return type 'int' makes
integer from pointer without a cast [-Wint-conversion]
error: expected identifier or '(' before '{' token

Fix these warnings and errors by fixing the return type of pruss APIs as
well as removing the misplaced semicolon from pruss_cfg_xfr_enable()

Fixes: 0211cc1e4fbb ("soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR")
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/20241220100508.1554309-2-danishanwar@ti.com
Signed-off-by: Nishanth Menon <nm@ti.com>
include/linux/pruss_driver.h

index c9a31c567e85bf0e3b14aa1e1e00d5118a2550ea..2e18fef1a2e109d5fbffb6572c7467683629c219 100644 (file)
@@ -144,32 +144,32 @@ static inline int pruss_release_mem_region(struct pruss *pruss,
 static inline int pruss_cfg_get_gpmux(struct pruss *pruss,
                                      enum pruss_pru_id pru_id, u8 *mux)
 {
-       return ERR_PTR(-EOPNOTSUPP);
+       return -EOPNOTSUPP;
 }
 
 static inline int pruss_cfg_set_gpmux(struct pruss *pruss,
                                      enum pruss_pru_id pru_id, u8 mux)
 {
-       return ERR_PTR(-EOPNOTSUPP);
+       return -EOPNOTSUPP;
 }
 
 static inline int pruss_cfg_gpimode(struct pruss *pruss,
                                    enum pruss_pru_id pru_id,
                                    enum pruss_gpi_mode mode)
 {
-       return ERR_PTR(-EOPNOTSUPP);
+       return -EOPNOTSUPP;
 }
 
 static inline int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable)
 {
-       return ERR_PTR(-EOPNOTSUPP);
+       return -EOPNOTSUPP;
 }
 
 static inline int pruss_cfg_xfr_enable(struct pruss *pruss,
                                       enum pru_type pru_type,
-                                      bool enable);
+                                      bool enable)
 {
-       return ERR_PTR(-EOPNOTSUPP);
+       return -EOPNOTSUPP;
 }
 
 #endif /* CONFIG_TI_PRUSS */