regulator: palmas: remove redundant initialization of pointer pdata
authorColin Ian King <colin.i.king@gmail.com>
Sat, 11 Nov 2023 19:53:30 +0000 (19:53 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 13 Nov 2023 01:26:31 +0000 (01:26 +0000)
Pointer pdata is being initialized with a value that is never read. It is
being re-assigned later on with the return from a devm_kzalloc call.
Remove the redundant initialization, cleans up clang scan build warning:

drivers/regulator/palmas-regulator.c:1597:36: warning: Value stored
to 'pdata' during its initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20231111195330.338324-1-colin.i.king@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/palmas-regulator.c

index e0dc033aae0f34269c2d1484ee33a9f7f23e18bd..60656a815b9ec906a123720932032812d5dd53b5 100644 (file)
@@ -1594,7 +1594,7 @@ static const struct of_device_id of_palmas_match_tbl[] = {
 static int palmas_regulators_probe(struct platform_device *pdev)
 {
        struct palmas *palmas = dev_get_drvdata(pdev->dev.parent);
-       struct palmas_pmic_platform_data *pdata = dev_get_platdata(&pdev->dev);
+       struct palmas_pmic_platform_data *pdata;
        struct device_node *node = pdev->dev.of_node;
        struct palmas_pmic_driver_data *driver_data;
        struct regulator_config config = { };