staging: rtl8192e: Remove unused variables txbeac.., txman.. and txcmdp..
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Wed, 25 Jan 2023 20:09:26 +0000 (21:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jan 2023 09:12:05 +0000 (10:12 +0100)
txbeaconerr, txmanageokint and txcmdpktokint are initialized and increased
but never read. Remove dead code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/6c922591c48512692f77729ac91849ebb4e61bd1.1674675808.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.h

index 4cc90425fa4ce364e14aa4abbc9ab612ee860446..2c5edda74e7331abe0fee0dfd5b3d0f10596a2ef 100644 (file)
@@ -2139,11 +2139,7 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev)
                goto done;
        }
 
-       if (inta & IMR_TBDER)
-               priv->stats.txbeaconerr++;
-
        if (inta  & IMR_MGNTDOK) {
-               priv->stats.txmanageokint++;
                _rtl92e_tx_isr(dev, MGNT_QUEUE);
                spin_unlock_irqrestore(&priv->irq_th_lock, flags);
                if (priv->rtllib->ack_tx_to_ieee) {
@@ -2155,10 +2151,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev)
                spin_lock_irqsave(&priv->irq_th_lock, flags);
        }
 
-       if (inta & IMR_COMDOK) {
-               priv->stats.txcmdpktokint++;
+       if (inta & IMR_COMDOK)
                _rtl92e_tx_isr(dev, TXCMD_QUEUE);
-       }
 
        if (inta & IMR_HIGHDOK)
                _rtl92e_tx_isr(dev, HIGH_QUEUE);
index f8b2201ea288cf950006e32145e4f45bad77420a..c6a4ac6ce959ebbda4f3fa25c9956b454cf8dac2 100644 (file)
@@ -184,9 +184,6 @@ enum reset_type {
 
 struct rt_stats {
        unsigned long received_rate_histogram[4][32];
-       unsigned long txbeaconerr;
-       unsigned long txmanageokint;
-       unsigned long txcmdpktokint;
        unsigned long txbytesmulticast;
        unsigned long txbytesbroadcast;
        unsigned long txbytesunicast;