ALSA: control: remove useless assignment in .info callback of PCM chmap element
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sat, 14 Dec 2019 13:13:51 +0000 (22:13 +0900)
committerTakashi Iwai <tiwai@suse.de>
Sat, 14 Dec 2019 15:39:05 +0000 (16:39 +0100)
Control elements for PCM chmap return information to userspace abount
the maximum number of available PCM channels as the number of values
in the element.

In current implementation the number is once initialized to zero, then
assigned to. This is useless and this commit fixes it.

Fixes: 2d3391ec0ecc ("ALSA: PCM: channel mapping API implementation")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20191214131351.28950-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_lib.c

index 2236b5e0c1f25d04e2ca2f2fa91114e118a4c47d..6f0a00fd3ae5e2fe155c2200539151e0994d0b0e 100644 (file)
@@ -2308,7 +2308,6 @@ static int pcm_chmap_ctl_info(struct snd_kcontrol *kcontrol,
        struct snd_pcm_chmap *info = snd_kcontrol_chip(kcontrol);
 
        uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
-       uinfo->count = 0;
        uinfo->count = info->max_channels;
        uinfo->value.integer.min = 0;
        uinfo->value.integer.max = SNDRV_CHMAP_LAST;