mm/damon/sysfs: remove parameters of damon_sysfs_region_alloc()
authorSeongJae Park <sj@kernel.org>
Wed, 26 Oct 2022 22:59:37 +0000 (22:59 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 30 Nov 2022 23:01:25 +0000 (15:01 -0800)
'damon_sysfs_region_alloc()' is always called with zero-filled 'struct
damon_addr_range', because the start and end addresses should set by
users.  Remove unnecessary parameters of the function and simplify the
body by using 'kzalloc()'.

Link: https://lkml.kernel.org/r/20221026225943.100429-7-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/sysfs.c

index a5ef503d84445946975b64e8a9a8dc4c974a22ff..f3d7b34ea0ab865081577f4104b851216f515447 100644 (file)
@@ -1065,17 +1065,9 @@ struct damon_sysfs_region {
        struct damon_addr_range ar;
 };
 
-static struct damon_sysfs_region *damon_sysfs_region_alloc(
-               struct damon_addr_range ar)
+static struct damon_sysfs_region *damon_sysfs_region_alloc(void)
 {
-       struct damon_sysfs_region *region = kmalloc(sizeof(*region),
-                       GFP_KERNEL);
-
-       if (!region)
-               return NULL;
-       region->kobj = (struct kobject){};
-       region->ar = ar;
-       return region;
+       return kzalloc(sizeof(struct damon_sysfs_region), GFP_KERNEL);
 }
 
 static ssize_t start_show(struct kobject *kobj, struct kobj_attribute *attr,
@@ -1184,7 +1176,7 @@ static int damon_sysfs_regions_add_dirs(struct damon_sysfs_regions *regions,
        regions->regions_arr = regions_arr;
 
        for (i = 0; i < nr_regions; i++) {
-               region = damon_sysfs_region_alloc((struct damon_addr_range){});
+               region = damon_sysfs_region_alloc();
                if (!region) {
                        damon_sysfs_regions_rm_dirs(regions);
                        return -ENOMEM;