staging: gpib: fix uninitialized variable in usb_gpib_command()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 17 Oct 2024 19:31:46 +0000 (22:31 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 19 Oct 2024 08:02:31 +0000 (10:02 +0200)
The number of bytes written is supposed to be zero at the start of this
function but only one caller, ibcmd(), initializes it to zero.  For the
other three callers, setup_serial_poll(), read_serial_poll_byte() and
cleanup_serial_poll(), it's an uninitialized variable.

Fixes: fce79512a96a ("staging: gpib: Add LPVO DIY USB GPIB driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/a7fed100-ea4d-4dd8-97c6-3fbd2c15f795@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c

index 2a8f127de427718a98af87d42865ab30a4a4cc3c..4c580137043f69d7ba10c3851e27b0d5a57da738 100644 (file)
@@ -597,6 +597,7 @@ static int usb_gpib_command(gpib_board_t *board,
 
        set_timeout(board);
 
+       *bytes_written = 0;
        for (i = 0 ; i < length ; i++) {
                command[3] = buffer[i];
                retval = send_command(board, command, 5);