cpufreq: Avoid printing kernel addresses in cpufreq_resume()
authorLiao Chang <liaochang1@huawei.com>
Tue, 29 Aug 2023 07:01:50 +0000 (07:01 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 29 Aug 2023 18:17:24 +0000 (20:17 +0200)
The pointer value of policy and driver structure are currently printed
in the error messages of cpufreq_resume(), this is not recommended and
helpful.

In order to be consistent with the error message in cpufreq_suspend()
and easier to understand, print the name of driver strcture and the
manage CPU of policy structure individually in the error messages of
cpufreq_resume().

Link: https://lore.kernel.org/all/b7be717c-41d8-bbbf-3e97-3799948ab757@huawei.com
Signed-off-by: Liao Chang <liaochang1@huawei.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c

index a757f90aa9d62848f49ce9f60b8b3c1125f888dd..bd7bb0d58ef0efb08311024161b2ac60a4b57c0e 100644 (file)
@@ -1943,16 +1943,16 @@ void cpufreq_resume(void)
 
        for_each_active_policy(policy) {
                if (cpufreq_driver->resume && cpufreq_driver->resume(policy)) {
-                       pr_err("%s: Failed to resume driver: %p\n", __func__,
-                               policy);
+                       pr_err("%s: Failed to resume driver: %s\n", __func__,
+                               cpufreq_driver->name);
                } else if (has_target()) {
                        down_write(&policy->rwsem);
                        ret = cpufreq_start_governor(policy);
                        up_write(&policy->rwsem);
 
                        if (ret)
-                               pr_err("%s: Failed to start governor for policy: %p\n",
-                                      __func__, policy);
+                               pr_err("%s: Failed to start governor for CPU%u's policy\n",
+                                      __func__, policy->cpu);
                }
        }
 }