cfq-iosched: Get rid of unnecessary local variable
authorVivek Goyal <vgoyal@redhat.com>
Wed, 3 Oct 2012 20:57:00 +0000 (16:57 -0400)
committerTejun Heo <tj@kernel.org>
Wed, 9 Jan 2013 16:05:09 +0000 (08:05 -0800)
Use of local varibale "n" seems to be unnecessary. Remove it. This brings
it inline with function __cfq_group_st_add(), which is also doing the
similar operation of adding a group to a rb tree.

No functionality change here.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
block/cfq-iosched.c

index e34e142b6dbb5beb33068cc3a79f71415d4f6258..5ad4cae1beb2726aced6cf2e69d3b51701126234 100644 (file)
@@ -1658,8 +1658,6 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq,
        cfqq->service_tree = st;
        p = &st->rb.rb_node;
        while (*p) {
-               struct rb_node **n;
-
                parent = *p;
                __cfqq = rb_entry(parent, struct cfq_queue, rb_node);
 
@@ -1667,13 +1665,11 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq,
                 * sort by key, that represents service time.
                 */
                if (time_before(rb_key, __cfqq->rb_key))
-                       n = &(*p)->rb_left;
+                       p = &parent->rb_left;
                else {
-                       n = &(*p)->rb_right;
+                       p = &parent->rb_right;
                        left = 0;
                }
-
-               p = n;
        }
 
        if (left)