spi: intel: Use correct order for the parameters of devm_kcalloc()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 21 May 2022 06:59:35 +0000 (08:59 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 6 Jun 2022 11:41:28 +0000 (12:41 +0100)
We should have 'n', then 'size', not the opposite.
This is harmless because the 2 values are just multiplied, but having
the correct order silence a (unpublished yet) smatch warning.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/d114558dd0351b863ced8cc01b31754a5a4b960d.1653116362.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-intel.c

index 50f42983b9502c838a57c5b345dbfc26deabdefc..66063687ae2714745f869ddb78c903b32fcf031b 100644 (file)
@@ -1236,8 +1236,8 @@ static int intel_spi_populate_chip(struct intel_spi *ispi)
                return -ENOMEM;
 
        pdata->nr_parts = 1;
-       pdata->parts = devm_kcalloc(ispi->dev, sizeof(*pdata->parts),
-                                   pdata->nr_parts, GFP_KERNEL);
+       pdata->parts = devm_kcalloc(ispi->dev, pdata->nr_parts,
+                                   sizeof(*pdata->parts), GFP_KERNEL);
        if (!pdata->parts)
                return -ENOMEM;