GFS2: Set gl_object during inode create
authorBob Peterson <rpeterso@redhat.com>
Wed, 21 Nov 2012 14:56:00 +0000 (09:56 -0500)
committerSteven Whitehouse <swhiteho@redhat.com>
Wed, 21 Nov 2012 14:49:21 +0000 (14:49 +0000)
This patch fixes a cluster coherency problem that occurs when one
node creates a file, does several writes, then a different node
tries to write to the same file. When the inode's glock is demoted,
the inode wasn't synced to the media properly because the gl_object
wasn't set. Later, the flush daemon noticed the uncommitted data
and tried to flush it, only to discover the glock was no longer locked
properly in exclusive mode. That caused an assert withdraw.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/inode.c

index 2405695febe9c157ced8bcdb72d9b6c083b15c18..2b6f5698ef18fb3ae489bc64e88ab5fd919855dd 100644 (file)
@@ -702,6 +702,7 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
        if (error)
                goto fail_free_inode;
 
+       ip->i_gl->gl_object = ip;
        error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, GL_SKIP, ghs + 1);
        if (error)
                goto fail_free_inode;