staging: gpib: fluke: struct gpib_interface
authorMichael Rubin <matchstick@neverthere.org>
Thu, 17 Apr 2025 00:32:35 +0000 (00:32 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Apr 2025 09:12:54 +0000 (11:12 +0200)
Using Linux code style for struct gpib_interface.

Adhering to Linux code style.

Reported by checkpatch.pl

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250417003246.84445-8-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/eastwood/fluke_gpib.c

index 396524901f1220015f17e32b104d7264446bf28f..f6a84200e3a1e91df9f4f0b2ba1892ae0ce6964e 100644 (file)
@@ -712,7 +712,7 @@ static int fluke_accel_read(struct gpib_board *board, u8 *buffer, size_t length,
        return retval;
 }
 
-static gpib_interface_t fluke_unaccel_interface = {
+static struct gpib_interface fluke_unaccel_interface = {
        .name = "fluke_unaccel",
        .attach = fluke_attach_holdoff_all,
        .detach = fluke_detach,
@@ -748,7 +748,7 @@ static gpib_interface_t fluke_unaccel_interface = {
  * register just as the dma controller is also doing a read.
  */
 
-static gpib_interface_t fluke_hybrid_interface = {
+static struct gpib_interface fluke_hybrid_interface = {
        .name = "fluke_hybrid",
        .attach = fluke_attach_holdoff_all,
        .detach = fluke_detach,
@@ -775,7 +775,7 @@ static gpib_interface_t fluke_hybrid_interface = {
        .return_to_local = fluke_return_to_local,
 };
 
-static gpib_interface_t fluke_interface = {
+static struct gpib_interface fluke_interface = {
        .name = "fluke",
        .attach = fluke_attach_holdoff_end,
        .detach = fluke_detach,