drm/amd/display: Fix the checking condition in dmub aux handling
authorWayne Lin <Wayne.Lin@amd.com>
Sun, 20 Apr 2025 08:29:07 +0000 (16:29 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 5 May 2025 17:01:44 +0000 (13:01 -0400)
[Why & How]
Fix the checking condition for detecting AUX_RET_ERROR_PROTOCOL_ERROR.
It was wrongly checking by "not equals to"

Reviewed-by: Ray Wu <ray.wu@amd.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Signed-off-by: Ray Wu <ray.wu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 31894e52f30799e4d1ee507c63c7983d5b06a202..2c4cae5e1a20374cdd4063933d952dcae2eadc2b 100644 (file)
@@ -12839,7 +12839,7 @@ int amdgpu_dm_process_dmub_aux_transfer_sync(
                 * Transient states before tunneling is enabled could
                 * lead to this error. We can ignore this for now.
                 */
-               if (p_notify->result != AUX_RET_ERROR_PROTOCOL_ERROR) {
+               if (p_notify->result == AUX_RET_ERROR_PROTOCOL_ERROR) {
                        drm_warn(adev_to_drm(adev), "DPIA AUX failed on 0x%x(%d), error %d\n",
                                        payload->address, payload->length,
                                        p_notify->result);