staging: rtl8192e: rtl819x_HTProc: make arrays const and one static
authorColin Ian King <colin.i.king@gmail.com>
Thu, 3 Nov 2022 13:06:19 +0000 (13:06 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Nov 2022 15:26:26 +0000 (16:26 +0100)
Make two dead-only arrays const. Make array EWC11NHTCap static const
so it is not populated on the stack, makes the code smaller too.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20221103130619.78413-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl819x_HTProc.c

index ccb86660ab48764e4906c14c3f625815b5255c5a..2c0a8d5c8f279d75883afcead1fefe92e8cbbb6f 100644 (file)
@@ -282,7 +282,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
        memset(posHTCap, 0, *len);
 
        if ((bAssoc) && (pHT->ePeerHTSpecVer == HT_SPEC_VER_EWC)) {
-               u8      EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
+               static const u8 EWC11NHTCap[] = { 0x00, 0x90, 0x4c, 0x33 };
 
                memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
                pCapELE = (struct ht_capab_ele *)&posHTCap[4];
@@ -515,8 +515,8 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
        u16 nMaxAMSDUSize = 0;
        u8 *pMcsFilter = NULL;
 
-       static u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
-       static u8 EWC11NHTInfo[] = {0x00, 0x90, 0x4c, 0x34};
+       static const u8 EWC11NHTCap[] = { 0x00, 0x90, 0x4c, 0x33 };
+       static const u8 EWC11NHTInfo[] = { 0x00, 0x90, 0x4c, 0x34 };
 
        if (!pHTInfo->bCurrentHTSupport) {
                netdev_warn(ieee->dev, "%s(): HT_DISABLE\n", __func__);