wifi: mwl8k: initialize cmd->addr[] properly
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 4 May 2024 11:38:15 +0000 (14:38 +0300)
committerKalle Valo <kvalo@kernel.org>
Tue, 7 May 2024 12:08:14 +0000 (15:08 +0300)
This loop is supposed to copy the mac address to cmd->addr but the
i++ increment is missing so it copies everything to cmd->addr[0] and
only the last address is recorded.

Fixes: 22bedad3ce11 ("net: convert multicast list to list_head")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/b788be9a-15f5-4cca-a3fe-79df4c8ce7b2@moroto.mountain
drivers/net/wireless/marvell/mwl8k.c

index 9e534e0a324a686e5e977285e383ea8bf7ec76bd..d3d07bb263352bf4963bf1edf3a55c494adb4d0b 100644 (file)
@@ -2720,7 +2720,7 @@ __mwl8k_cmd_mac_multicast_adr(struct ieee80211_hw *hw, int allmulti,
                cmd->action |= cpu_to_le16(MWL8K_ENABLE_RX_MULTICAST);
                cmd->numaddr = cpu_to_le16(mc_count);
                netdev_hw_addr_list_for_each(ha, mc_list) {
-                       memcpy(cmd->addr[i], ha->addr, ETH_ALEN);
+                       memcpy(cmd->addr[i++], ha->addr, ETH_ALEN);
                }
        }