drm/amd/amdgpu: hide voltage and power sensors on SI and KV parts
authorJean Delvare <jdelvare@suse.de>
Wed, 28 Aug 2019 08:27:29 +0000 (10:27 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 29 Aug 2019 20:52:32 +0000 (15:52 -0500)
The driver does not support these sensors yet and there is no point in
creating sysfs attributes which will always return an error.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "David (ChunMing) Zhou" <David1.Zhou@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

index 2fccaf412e030f1839388ecd5cb4ef7a231469d5..03930313c2638f5138a6a023a0a06c58cb804e68 100644 (file)
@@ -2349,7 +2349,9 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj,
                        effective_mode &= ~S_IWUSR;
        }
 
-       if ((adev->flags & AMD_IS_APU) &&
+       if (((adev->flags & AMD_IS_APU) ||
+            adev->family == AMDGPU_FAMILY_SI ||        /* not implemented yet */
+            adev->family == AMDGPU_FAMILY_KV) &&       /* not implemented yet */
            (attr == &sensor_dev_attr_power1_average.dev_attr.attr ||
             attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr ||
             attr == &sensor_dev_attr_power1_cap_min.dev_attr.attr||
@@ -2373,6 +2375,12 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj,
                        return 0;
        }
 
+       if ((adev->family == AMDGPU_FAMILY_SI ||        /* not implemented yet */
+            adev->family == AMDGPU_FAMILY_KV) &&       /* not implemented yet */
+           (attr == &sensor_dev_attr_in0_input.dev_attr.attr ||
+            attr == &sensor_dev_attr_in0_label.dev_attr.attr))
+               return 0;
+
        /* only APUs have vddnb */
        if (!(adev->flags & AMD_IS_APU) &&
            (attr == &sensor_dev_attr_in1_input.dev_attr.attr ||