drm/i915/display: convert params to struct intel_display
authorJani Nikula <jani.nikula@intel.com>
Thu, 22 Aug 2024 16:04:55 +0000 (19:04 +0300)
committerJani Nikula <jani.nikula@intel.com>
Fri, 23 Aug 2024 08:52:04 +0000 (11:52 +0300)
Going forward, struct intel_display shall replace struct
drm_i915_private as the main display device data pointer type. Convert
intel_display_params.[ch] and intel_display_debugfs_params.[ch] to
struct intel_display.

Some stragglers are left behind where needed.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/3e5cc1744eaf4708b08303e3e7e194035d7941cc.1724342644.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_display_debugfs.c
drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
drivers/gpu/drm/i915/display/intel_display_debugfs_params.h
drivers/gpu/drm/i915/display/intel_display_params.c
drivers/gpu/drm/i915/display/intel_display_params.h
drivers/gpu/drm/i915/i915_debugfs.c
drivers/gpu/drm/i915/i915_gpu_error.c

index 0cf0b422351372cadd4abf9589c531893056cc67..74f527647aa907c2e4c29e398ab44462e472020d 100644 (file)
@@ -1073,7 +1073,7 @@ void intel_display_debugfs_register(struct drm_i915_private *i915)
        intel_opregion_debugfs_register(display);
        intel_psr_debugfs_register(i915);
        intel_wm_debugfs_register(i915);
-       intel_display_debugfs_params(i915);
+       intel_display_debugfs_params(display);
 }
 
 static int i915_hdcp_sink_capability_show(struct seq_file *m, void *data)
index f3571874855551e7bafce48fd5e5a50b6fd6da56..ec3ed29a83c935ae84b41f43492a1ec4383af37a 100644 (file)
@@ -151,13 +151,13 @@ intel_display_debugfs_create_uint(const char *name, umode_t mode,
        } while (0)
 
 /* add a subdirectory with files for each intel display param */
-void intel_display_debugfs_params(struct drm_i915_private *i915)
+void intel_display_debugfs_params(struct intel_display *display)
 {
-       struct drm_minor *minor = i915->drm.primary;
+       struct drm_minor *minor = display->drm->primary;
        struct dentry *dir;
        char dirname[16];
 
-       snprintf(dirname, sizeof(dirname), "%s_params", i915->drm.driver->name);
+       snprintf(dirname, sizeof(dirname), "%s_params", display->drm->driver->name);
        dir = debugfs_lookup(dirname, minor->debugfs_root);
        if (!dir)
                dir = debugfs_create_dir(dirname, minor->debugfs_root);
@@ -171,7 +171,7 @@ void intel_display_debugfs_params(struct drm_i915_private *i915)
         */
 
 #define REGISTER(T, x, unused, mode, ...) _intel_display_param_create_file( \
-               dir, #x, mode, &i915->display.params.x);
+               dir, #x, mode, &display->params.x);
        INTEL_DISPLAY_PARAMS_FOR_EACH(REGISTER);
 #undef REGISTER
 }
index 1e9945a4044c0707c7e8ecba185ff868b71254da..a1120915a5a8ef699c4c5914532f455bbe8e7364 100644 (file)
@@ -6,8 +6,8 @@
 #ifndef __INTEL_DISPLAY_DEBUGFS_PARAMS__
 #define __INTEL_DISPLAY_DEBUGFS_PARAMS__
 
-struct drm_i915_private;
+struct intel_display;
 
-void intel_display_debugfs_params(struct drm_i915_private *i915);
+void intel_display_debugfs_params(struct intel_display *display);
 
 #endif /* __INTEL_DISPLAY_DEBUGFS_PARAMS__ */
index e82bd72d32faf4af94aaf72da3d307cc372f59c3..1a45d300b6f0fa73e3c1016ee808ca7c23e6ce76 100644 (file)
@@ -173,14 +173,14 @@ static void _param_print_charp(struct drm_printer *p, const char *driver_name,
 
 /**
  * intel_display_params_dump - dump intel display modparams
- * @i915: i915 device
+ * @display: display device
  * @p: the &drm_printer
  *
  * Pretty printer for i915 modparams.
  */
-void intel_display_params_dump(struct drm_i915_private *i915, struct drm_printer *p)
+void intel_display_params_dump(struct intel_display *display, struct drm_printer *p)
 {
-#define PRINT(T, x, ...) _param_print(p, i915->drm.driver->name, #x, i915->display.params.x);
+#define PRINT(T, x, ...) _param_print(p, display->drm->driver->name, #x, display->params.x);
        INTEL_DISPLAY_PARAMS_FOR_EACH(PRINT);
 #undef PRINT
 }
index 48c29c55c939bc1040a9c217568a7d079ab701b2..da8dc943234b773874c248cba60356e0e5ff35fe 100644 (file)
@@ -9,7 +9,7 @@
 #include <linux/types.h>
 
 struct drm_printer;
-struct drm_i915_private;
+struct intel_display;
 
 /*
  * Invoke param, a function-like macro, for each intel display param, with
@@ -56,7 +56,7 @@ struct intel_display_params {
 };
 #undef MEMBER
 
-void intel_display_params_dump(struct drm_i915_private *i915,
+void intel_display_params_dump(struct intel_display *display,
                               struct drm_printer *p);
 void intel_display_params_copy(struct intel_display_params *dest);
 void intel_display_params_free(struct intel_display_params *params);
index bc717cf544e429be84b6138ef00328bb5c96733e..f969f585d07b98859bbba6c14540813f7b0a3b9d 100644 (file)
@@ -66,6 +66,7 @@ static inline struct drm_i915_private *node_to_i915(struct drm_info_node *node)
 static int i915_capabilities(struct seq_file *m, void *data)
 {
        struct drm_i915_private *i915 = node_to_i915(m->private);
+       struct intel_display *display = &i915->display;
        struct drm_printer p = drm_seq_file_printer(m);
 
        seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(i915));
@@ -77,7 +78,7 @@ static int i915_capabilities(struct seq_file *m, void *data)
 
        kernel_param_lock(THIS_MODULE);
        i915_params_dump(&i915->params, &p);
-       intel_display_params_dump(i915, &p);
+       intel_display_params_dump(display, &p);
        kernel_param_unlock(THIS_MODULE);
 
        return 0;
index 96c6cafd5b9e4fd99b674c3b3dd97e34650dcc86..6469b9bcf2ec4475aff62cec7d3b652f4c16a866 100644 (file)
@@ -660,9 +660,10 @@ static void err_print_params(struct drm_i915_error_state_buf *m,
                             const struct i915_params *params)
 {
        struct drm_printer p = i915_error_printer(m);
+       struct intel_display *display = &m->i915->display;
 
        i915_params_dump(params, &p);
-       intel_display_params_dump(m->i915, &p);
+       intel_display_params_dump(display, &p);
 }
 
 static void err_print_pciid(struct drm_i915_error_state_buf *m,