net: txgbe: Remove unnecessary NULL check before free
authorSimon Horman <horms@kernel.org>
Thu, 15 Aug 2024 15:19:25 +0000 (16:19 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 16 Aug 2024 23:19:34 +0000 (16:19 -0700)
Remove unnecessary NULL check before freeing using kvfree().
This function will ignore a NULL argument.

Flagged by Coccinelle:

  .../txgbe_hw.c:187:2-8: WARNING: NULL check before some freeing functions is not needed.

No functional change intended.
Compile tested only.

Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240815-txgbe-kvfree-v1-1-5ecf8656f555@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c

index d6b2b3c781b6f2b25f6349c020af38e75c77b359..cd1372da92a94cd5114ba177f4ee9131510432de 100644 (file)
@@ -103,8 +103,7 @@ static int txgbe_calc_eeprom_checksum(struct wx *wx, u16 *checksum)
                if (i != wx->eeprom.sw_region_offset + TXGBE_EEPROM_CHECKSUM)
                        *checksum += local_buffer[i];
 
-       if (eeprom_ptrs)
-               kvfree(eeprom_ptrs);
+       kvfree(eeprom_ptrs);
 
        *checksum = TXGBE_EEPROM_SUM - *checksum;