drm/xe: Don't emit extra MI_BATCH_BUFFER_END in WA batchbuffer
authorMatt Roper <matthew.d.roper@intel.com>
Wed, 29 Mar 2023 17:33:34 +0000 (10:33 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 19 Dec 2023 23:30:27 +0000 (18:30 -0500)
The MI_BATCH_BUFFER_END is already added automatically by
__xe_bb_create_job(); including it in the construction of the workaround
batchbuffer results in an unnecessary duplicate.

Link: https://lore.kernel.org/r/20230329173334.4015124-4-matthew.d.roper@intel.com
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_gt.c

index fd7a5b43ba3e3fd507f767d88337e7887d790fdd..bc821f431c45ab0eed2afa390e6741ecd7616b57 100644 (file)
@@ -203,8 +203,6 @@ static int emit_wa_job(struct xe_gt *gt, struct xe_engine *e)
                        bb->cs[bb->len++] = entry->set_bits;
                }
        }
-       bb->cs[bb->len++] = MI_NOOP;
-       bb->cs[bb->len++] = MI_BATCH_BUFFER_END;
 
        batch_ofs = xe_bo_ggtt_addr(gt->kernel_bb_pool.bo);
        job = xe_bb_create_wa_job(e, bb, batch_ofs);