iio: accel: fxls8962af-core: Make use of regmap_set_bits(), regmap_clear_bits()
authorTrevor Gamblin <tgamblin@baylibre.com>
Mon, 17 Jun 2024 13:49:41 +0000 (09:49 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 25 Jun 2024 20:04:43 +0000 (21:04 +0100)
Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-1-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/fxls8962af-core.c

index 4fbc01bda62e4ccc06f993ac244ac99a7c32c19a..d25e316134131a6b7960a564a643b291a0aa0f82 100644 (file)
@@ -228,8 +228,8 @@ static int fxls8962af_power_off(struct fxls8962af_data *data)
 
 static int fxls8962af_standby(struct fxls8962af_data *data)
 {
-       return regmap_update_bits(data->regmap, FXLS8962AF_SENS_CONFIG1,
-                                 FXLS8962AF_SENS_CONFIG1_ACTIVE, 0);
+       return regmap_clear_bits(data->regmap, FXLS8962AF_SENS_CONFIG1,
+                                FXLS8962AF_SENS_CONFIG1_ACTIVE);
 }
 
 static int fxls8962af_active(struct fxls8962af_data *data)
@@ -785,9 +785,8 @@ static int fxls8962af_reset(struct fxls8962af_data *data)
        unsigned int reg;
        int ret;
 
-       ret = regmap_update_bits(data->regmap, FXLS8962AF_SENS_CONFIG1,
-                                FXLS8962AF_SENS_CONFIG1_RST,
-                                FXLS8962AF_SENS_CONFIG1_RST);
+       ret = regmap_set_bits(data->regmap, FXLS8962AF_SENS_CONFIG1,
+                             FXLS8962AF_SENS_CONFIG1_RST);
        if (ret)
                return ret;
 
@@ -830,9 +829,8 @@ static int fxls8962af_buffer_postenable(struct iio_dev *indio_dev)
        fxls8962af_standby(data);
 
        /* Enable buffer interrupt */
-       ret = regmap_update_bits(data->regmap, FXLS8962AF_INT_EN,
-                                FXLS8962AF_INT_EN_BUF_EN,
-                                FXLS8962AF_INT_EN_BUF_EN);
+       ret = regmap_set_bits(data->regmap, FXLS8962AF_INT_EN,
+                             FXLS8962AF_INT_EN_BUF_EN);
        if (ret)
                return ret;
 
@@ -851,8 +849,8 @@ static int fxls8962af_buffer_predisable(struct iio_dev *indio_dev)
        fxls8962af_standby(data);
 
        /* Disable buffer interrupt */
-       ret = regmap_update_bits(data->regmap, FXLS8962AF_INT_EN,
-                                FXLS8962AF_INT_EN_BUF_EN, 0);
+       ret = regmap_clear_bits(data->regmap, FXLS8962AF_INT_EN,
+                               FXLS8962AF_INT_EN_BUF_EN);
        if (ret)
                return ret;