bcachefs: Use btree write buffer for LRU btree

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c
index 81bd56152fd023c4fa02202676b4dbb4bf7aca51..af3e55fdd54a7378dc416d79687f3e2cf40584d5 100644 (file)
--- a/fs/bcachefs/alloc_background.c
+++ b/fs/bcachefs/alloc_background.c
@@ -9,6 +9,7 @@
 #include "btree_update.h"
 #include "btree_update_interior.h"
 #include "btree_gc.h"
+#include "btree_write_buffer.h"
 #include "buckets.h"
 #include "buckets_waiting_for_journal.h"
 #include "clock.h"
@@ -1775,15 +1776,11 @@ static int invalidate_one_bucket(struct btree_trans *trans,
        if (ret)
                goto out;
 
-       if (lru_pos_time(lru_iter->pos) != alloc_lru_idx(a->v)) {
-               prt_str(&buf, "alloc key does not point back to lru entry when invalidating bucket:");
-               goto err;
-       }
+       /* We expect harmless races here due to the btree write buffer: */
+       if (lru_pos_time(lru_iter->pos) != alloc_lru_idx(a->v))
+               goto out;
 
-       if (a->v.data_type != BCH_DATA_cached) {
-               prt_str(&buf, "lru entry points to non cached bucket:");
-               goto err;
-       }
+       BUG_ON(a->v.data_type != BCH_DATA_cached);
 
        if (!a->v.cached_sectors)
                bch_err(c, "invalidating empty bucket, confused");
@@ -1845,6 +1842,10 @@ static void bch2_do_invalidates_work(struct work_struct *work)
 
        bch2_trans_init(&trans, c, 0, 0);
 
+       ret = bch2_btree_write_buffer_flush(&trans);
+       if (ret)
+               goto err;
+
        for_each_member_device(ca, c, i) {
                s64 nr_to_invalidate =
                        should_invalidate_buckets(ca, bch2_dev_usage_read(ca));
@@ -1860,7 +1861,7 @@ static void bch2_do_invalidates_work(struct work_struct *work)
                        break;
                }
        }
-
+err:
        bch2_trans_exit(&trans);
        bch2_write_ref_put(c, BCH_WRITE_REF_invalidate);
 }

diff --git a/fs/bcachefs/lru.c b/fs/bcachefs/lru.c
index 07fb41ca8c6b4e2e7d12d8cb4948ba499039fc77..c121a7cc3acd1b11767bb0467c743aa21f400454 100644 (file)
--- a/fs/bcachefs/lru.c
+++ b/fs/bcachefs/lru.c
@@ -4,6 +4,7 @@
 #include "alloc_background.h"
 #include "btree_iter.h"
 #include "btree_update.h"
+#include "btree_write_buffer.h"
 #include "error.h"
 #include "lru.h"
 #include "recovery.h"
@@ -49,7 +50,6 @@ void bch2_lru_pos_to_text(struct printbuf *out, struct bpos lru)
 static int __bch2_lru_set(struct btree_trans *trans, u16 lru_id,
                        u64 dev_bucket, u64 time, unsigned key_type)
 {
-       struct btree_iter iter;
        struct bkey_i *k;
        int ret = 0;
 
@@ -69,13 +69,7 @@ static int __bch2_lru_set(struct btree_trans *trans, u16 lru_id,
        EBUG_ON(lru_pos_time(k->k.p) != time);
        EBUG_ON(k->k.p.offset != dev_bucket);
 
-       bch2_trans_iter_init(trans, &iter, BTREE_ID_lru,
-                            k->k.p, BTREE_ITER_INTENT);
-
-       ret = bch2_btree_iter_traverse(&iter) ?:
-               bch2_trans_update(trans, &iter, k, 0);
-       bch2_trans_iter_exit(trans, &iter);
-       return ret;
+       return bch2_trans_update_buffered(trans, BTREE_ID_lru, k);
 }
 
 int bch2_lru_del(struct btree_trans *trans, u16 lru_id, u64 dev_bucket, u64 time)
@@ -101,7 +95,8 @@ int bch2_lru_change(struct btree_trans *trans,
 
 static int bch2_check_lru_key(struct btree_trans *trans,
                              struct btree_iter *lru_iter,
-                             struct bkey_s_c lru_k)
+                             struct bkey_s_c lru_k,
+                             struct bpos *last_flushed_pos)
 {
        struct bch_fs *c = trans->c;
        struct btree_iter iter;
@@ -126,18 +121,29 @@ static int bch2_check_lru_key(struct btree_trans *trans,
 
        a = bch2_alloc_to_v4(k, &a_convert);
 
-       if (fsck_err_on(lru_k.k->type != KEY_TYPE_set ||
-                       a->data_type != BCH_DATA_cached ||
-                       a->io_time[READ] != lru_pos_time(lru_k.k->p), c,
-                       "incorrect lru entry (time %llu) %s\n"
-                       "  for %s",
-                       lru_pos_time(lru_k.k->p),
-                       (bch2_bkey_val_to_text(&buf1, c, lru_k), buf1.buf),
-                       (bch2_bkey_val_to_text(&buf2, c, k), buf2.buf))) {
-               ret = bch2_btree_delete_at(trans, lru_iter, 0);
-               if (ret)
-                       goto err;
+       if (lru_k.k->type != KEY_TYPE_set ||
+           a->data_type != BCH_DATA_cached ||
+           a->io_time[READ] != lru_pos_time(lru_k.k->p)) {}
+               if (!bpos_eq(*last_flushed_pos, lru_k.k->p)) {
+                       *last_flushed_pos = lru_k.k->p;
+                       ret = bch2_btree_write_buffer_flush_sync(trans) ?:
+                               -BCH_ERR_transaction_restart_write_buffer_flush;
+                       goto out;
+               }
+
+               if (fsck_err_on(lru_k.k->type != KEY_TYPE_set ||
+                               a->data_type != BCH_DATA_cached ||
+                               a->io_time[READ] != lru_pos_time(lru_k.k->p), c,
+                               "incorrect lru entry (time %llu) %s\n"
+                               "  for %s",
+                               lru_pos_time(lru_k.k->p),
+                               (bch2_bkey_val_to_text(&buf1, c, lru_k), buf1.buf),
+                               (bch2_bkey_val_to_text(&buf2, c, k), buf2.buf))) {
+                       ret = bch2_btree_delete_at(trans, lru_iter, 0);
+                       if (ret)
+                               goto err;
        }
+out:
 err:
 fsck_err:
        bch2_trans_iter_exit(trans, &iter);
@@ -151,6 +157,7 @@ int bch2_check_lrus(struct bch_fs *c)
        struct btree_trans trans;
        struct btree_iter iter;
        struct bkey_s_c k;
+       struct bpos last_flushed_pos = POS_MIN;
        int ret = 0;
 
        bch2_trans_init(&trans, c, 0, 0);
@@ -158,7 +165,7 @@ int bch2_check_lrus(struct bch_fs *c)
        ret = for_each_btree_key_commit(&trans, iter,
                        BTREE_ID_lru, POS_MIN, BTREE_ITER_PREFETCH, k,
                        NULL, NULL, BTREE_INSERT_NOFAIL|BTREE_INSERT_LAZY_RW,
-               bch2_check_lru_key(&trans, &iter, k));
+               bch2_check_lru_key(&trans, &iter, k, &last_flushed_pos));
 
        bch2_trans_exit(&trans);
        return ret;