clk: visconti: Switch to use kmemdup_array()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 14 Aug 2024 12:54:08 +0000 (15:54 +0300)
committerStephen Boyd <sboyd@kernel.org>
Thu, 15 Aug 2024 00:37:25 +0000 (17:37 -0700)
Let the kmemdup_array() take care about multiplication and possible
overflows.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240814125513.2637955-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/visconti/pll.c

index e9cd80e085dc3b9f4c4ef41e901d40b31e49bc6e..3f929cf8dd2f71d5a57986b917c86fa4fc9e0ffd 100644 (file)
@@ -262,9 +262,9 @@ static struct clk_hw *visconti_register_pll(struct visconti_pll_provider *ctx,
        for (len = 0; rate_table[len].rate != 0; )
                len++;
        pll->rate_count = len;
-       pll->rate_table = kmemdup(rate_table,
-                                 pll->rate_count * sizeof(struct visconti_pll_rate_table),
-                                 GFP_KERNEL);
+       pll->rate_table = kmemdup_array(rate_table,
+                                       pll->rate_count, sizeof(*pll->rate_table),
+                                       GFP_KERNEL);
        WARN(!pll->rate_table, "%s: could not allocate rate table for %s\n", __func__, name);
 
        init.ops = &visconti_pll_ops;