Revert "drm/amd/display: Revised for Replay Pseudo vblank"
authorGabe Teeger <Gabe.Teeger@amd.com>
Thu, 28 Nov 2024 14:19:09 +0000 (09:19 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 10 Dec 2024 15:32:39 +0000 (10:32 -0500)
This reverts commit 0f5ac8c8e275
Due to a replay regression.

Fixes: 0f5ac8c8e275 ("drm/amd/display: Revised for Replay Pseudo vblank control")
Reviewed-by: Dennis Chan <dennis.chan@amd.com>
Signed-off-by: Gabe Teeger <Gabe.Teeger@amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dc_types.h
drivers/gpu/drm/amd/display/modules/power/power_helpers.c
drivers/gpu/drm/amd/display/modules/power/power_helpers.h

index 025ab521be255552cbf0ac84ea059d9f243f4f4b..edf4df1d03b58ca97a23bfe97f7bd9651b21517b 100644 (file)
@@ -1126,8 +1126,8 @@ struct replay_settings {
        uint32_t defer_update_coasting_vtotal_table[PR_COASTING_TYPE_NUM];
        /* Maximum link off frame count */
        uint32_t link_off_frame_count;
-       /* Replay pseudo vtotal for low refresh rate*/
-       uint16_t low_rr_full_screen_video_pseudo_vtotal;
+       /* Replay pseudo vtotal for abm + ips on full screen video which can improve ips residency */
+       uint16_t abm_with_ips_on_full_screen_video_pseudo_vtotal;
        /* Replay last pseudo vtotal set to DMUB */
        uint16_t last_pseudo_vtotal;
 };
index 85400ef5013acde441a684e0b75c84ffdb870d53..95838c7ab05431277075d5788307e0ea6f3b3492 100644 (file)
@@ -996,9 +996,9 @@ void set_replay_coasting_vtotal(struct dc_link *link,
        link->replay_settings.coasting_vtotal_table[type] = vtotal;
 }
 
-void set_replay_low_rr_full_screen_video_src_vtotal(struct dc_link *link, uint16_t vtotal)
+void set_replay_ips_full_screen_video_src_vtotal(struct dc_link *link, uint16_t vtotal)
 {
-       link->replay_settings.low_rr_full_screen_video_pseudo_vtotal = vtotal;
+       link->replay_settings.abm_with_ips_on_full_screen_video_pseudo_vtotal = vtotal;
 }
 
 void calculate_replay_link_off_frame_count(struct dc_link *link,
index 43ceeec417f58565f87a1fe7320d42fb9ef6fa2e..cac302e8fa1031cd6473b59ab3ca1b7f483eb612 100644 (file)
@@ -62,7 +62,7 @@ void set_replay_defer_update_coasting_vtotal(struct dc_link *link,
        uint32_t vtotal);
 void update_replay_coasting_vtotal_from_defer(struct dc_link *link,
        enum replay_coasting_vtotal_type type);
-void set_replay_low_rr_full_screen_video_src_vtotal(struct dc_link *link, uint16_t vtotal);
+void set_replay_ips_full_screen_video_src_vtotal(struct dc_link *link, uint16_t vtotal);
 void calculate_replay_link_off_frame_count(struct dc_link *link,
        uint16_t vtotal, uint16_t htotal);