crypto: tcrypt - Fix multibuffer skcipher speed test mem leak
authorZhang Yiqun <zhangyiqun@phytium.com.cn>
Wed, 16 Nov 2022 09:24:11 +0000 (17:24 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 25 Nov 2022 09:39:18 +0000 (17:39 +0800)
In the past, the data for mb-skcipher test has been allocated
twice, that means the first allcated memory area is without
free, which may cause a potential memory leakage. So this
patch is to remove one allocation to fix this error.

Fixes: e161c5930c15 ("crypto: tcrypt - add multibuf skcipher...")
Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/tcrypt.c

index 0f101897e90fb38d567cd8325d30df836b65c270..a0833654ce946d25320b29665ac9e23841ab06dd 100644 (file)
@@ -1090,15 +1090,6 @@ static void test_mb_skcipher_speed(const char *algo, int enc, int secs,
                        goto out_free_tfm;
                }
 
-
-       for (i = 0; i < num_mb; ++i)
-               if (testmgr_alloc_buf(data[i].xbuf)) {
-                       while (i--)
-                               testmgr_free_buf(data[i].xbuf);
-                       goto out_free_tfm;
-               }
-
-
        for (i = 0; i < num_mb; ++i) {
                data[i].req = skcipher_request_alloc(tfm, GFP_KERNEL);
                if (!data[i].req) {