drm/msm/dpu: correct dpu_plane_virtual_atomic_check()
authorDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Tue, 15 Jul 2025 17:28:18 +0000 (20:28 +0300)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Wed, 13 Aug 2025 17:18:52 +0000 (20:18 +0300)
Fix c&p error in dpu_plane_virtual_atomic_check(), compare CRTC width
too, in addition to CRTC height.

Fixes: 8c62a31607f6 ("drm/msm/dpu: allow using two SSPP blocks for a single plane")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507150432.U0cALR6W-lkp@intel.com/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/664170/
Link: https://lore.kernel.org/r/20250715-msm-fix-virt-atomic-check-v1-1-9bab02c9f952@oss.qualcomm.com
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

index 01171c535a27c8983aab6450d6f7a4316ae9c4ee..c722f54e71b03b78f3de82fec4f2d291d95bbba3 100644 (file)
@@ -1162,7 +1162,7 @@ static int dpu_plane_virtual_atomic_check(struct drm_plane *plane,
        if (!old_plane_state || !old_plane_state->fb ||
            old_plane_state->src_w != plane_state->src_w ||
            old_plane_state->src_h != plane_state->src_h ||
-           old_plane_state->src_w != plane_state->src_w ||
+           old_plane_state->crtc_w != plane_state->crtc_w ||
            old_plane_state->crtc_h != plane_state->crtc_h ||
            msm_framebuffer_format(old_plane_state->fb) !=
            msm_framebuffer_format(plane_state->fb))