drm/xe: Fix uninitialized pointer def
authorColin Ian King <colin.i.king@gmail.com>
Wed, 26 Feb 2025 16:05:24 +0000 (16:05 +0000)
committerLucas De Marchi <lucas.demarchi@intel.com>
Wed, 26 Feb 2025 16:29:30 +0000 (08:29 -0800)
In the case where a set of checks on xe->info.platform don't assign
a value to pointer def the pointer remains uninitialized and hence
can fail the following !def check. Fix this be ensuring pointer
def is initialized to NULL.

Fixes: 292b1a8a5054 ("drm/xe: Stop ignoring errors from xe_heci_gsc_init()")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250226160524.566074-1-colin.i.king@gmail.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_heci_gsc.c

index 3ea325d3db99d7228ad21cb3671800e0c8414485..27d11e06a82b493918b000b8cdbc8b10d0b19377 100644 (file)
@@ -173,7 +173,7 @@ static int heci_gsc_add_device(struct xe_device *xe, const struct heci_gsc_def *
 int xe_heci_gsc_init(struct xe_device *xe)
 {
        struct xe_heci_gsc *heci_gsc = &xe->heci_gsc;
-       const struct heci_gsc_def *def;
+       const struct heci_gsc_def *def = NULL;
        int ret;
 
        if (!xe->info.has_heci_gscfi && !xe->info.has_heci_cscfi)