net/mlx5: HWS, prevent rehash from filling up the queues
authorYevgeny Kliteynik <kliteyn@nvidia.com>
Sun, 17 Aug 2025 20:23:20 +0000 (23:23 +0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 20 Aug 2025 02:35:13 +0000 (19:35 -0700)
While moving the rules during rehash, CQ is not drained. The flush
and drain happens only when all the rules of a certain queue have been
moved. This behaviour can lead to accumulating large quantity of rules
that haven't got their completion yet, and eventually will fill up
the queue and will cause the rehash to fail.

Fix this problem by requiring drain once the number of outstanding
completions reaches a certain threshold.

Fixes: ef94799a8741 ("net/mlx5: HWS, rework rehash loop")
Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
Reviewed-by: Vlad Dogaru <vdogaru@nvidia.com>
Signed-off-by: Mark Bloch <mbloch@nvidia.com>
Link: https://patch.msgid.link/20250817202323.308604-5-mbloch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c

index 0219a49b23264d9aea1d74a095d38ace1faf5619..2a59be11fe5511538bc84fbd0b73909aa92ecf3f 100644 (file)
@@ -84,6 +84,7 @@ hws_bwc_matcher_move_all_simple(struct mlx5hws_bwc_matcher *bwc_matcher)
        struct list_head *rules_list;
        u32 pending_rules;
        int i, ret = 0;
+       bool drain;
 
        mlx5hws_bwc_rule_fill_attr(bwc_matcher, 0, 0, &rule_attr);
 
@@ -111,10 +112,12 @@ hws_bwc_matcher_move_all_simple(struct mlx5hws_bwc_matcher *bwc_matcher)
                        }
 
                        pending_rules++;
+                       drain = pending_rules >=
+                               hws_bwc_get_burst_th(ctx, rule_attr.queue_id);
                        ret = mlx5hws_bwc_queue_poll(ctx,
                                                     rule_attr.queue_id,
                                                     &pending_rules,
-                                                    false);
+                                                    drain);
                        if (unlikely(ret)) {
                                if (ret == -ETIMEDOUT) {
                                        mlx5hws_err(ctx,